Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference-models-in-another-project.md #4209

Merged
merged 13 commits into from
Oct 10, 2023
Merged

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Oct 6, 2023

remove faq page and direct users to source

Closes #4026

add info on project dependencies. 

Closes #4026
@mirnawong1 mirnawong1 requested a review from a team as a code owner October 6, 2023 13:13
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 9:59am

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Oct 6, 2023
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs-getdbt-com-git-mirnawong1-patch-12-dbt-labs.vercel.app/faqs/models/reference-models-in-another-project isn't redirecting (when Models is lowercase). I guess this is another instance of vercel being case sensitive - is there a way to work around that? at minimum I think we'll need to just add a redirect for the lowercase version too.


1. **Packages**: You can install [packages](/docs/build/packages) as a way to add another project to your dbt project, including other projects you've created. When you install a project as a package, you bring in its entire source code, making its macros and models available in your own project.

While this is useful for reusing code and sharing macros, it may not be the best approach for large-scale collaboration, especially in larger organizations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
While this is useful for reusing code and sharing macros, it may not be the best approach for large-scale collaboration, especially in larger organizations.
This is a useful way to share macros between projects, but is impractical for sharing models at scale because the importing project has to process the full source code of the upstream project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, thanks for testing that @joellabes ! I've added the lowercase redirect but i don't think there's any other way around it. I'm going to cc @john-rock @JKarlavige or @breezyfasano in case they have more insight?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok tested it and it worked! thanks @joellabes !

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a redirect is definitely the quickest fix. I have a task to look into the Vercel URLs to see how we can serve the same page both lower and capital case in URLs. Here's a link to the ticket https://app.asana.com/0/1200099998847559/1205508339405074/f

Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime this lgtm!

@mirnawong1 mirnawong1 merged commit 25d89c8 into current Oct 10, 2023
7 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-12 branch October 10, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cross project faqs
3 participants